fix: validate on_low_score trust-gate policies - #350
Merged
kevincostner17 merged 1 commit intoSep 15, 2026
Merged
Conversation
Reject invalid on_low_score values at integration boundaries so configuration typos cannot silently bypass failure handling. Co-authored-by: insisong <emmanuelisaacnsisong@gmail.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 15, 2026
kevincostner17
added a commit
that referenced
this pull request
Sep 15, 2026
CI, Benchmark and Performance regression used one concurrency group per ref with cancel-in-progress. On main, a later push, the scheduled run or a manual dispatch therefore cancelled the run already in progress. The nightly CI started at 08:32Z on 2026-09-15 and cancelled the push run for #350, which left 8 cancelled checks on 28072bf even though the same commit passed in full. Merging several PRs back to back would cancel the CI of every merge except the last. Group runs by event as well as ref, and cancel only when a newer push supersedes a pull_request run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #345
on_low_scoreis a typed literal, but values loaded from configuration bypass static checks. A typo could silently skip both failure and skip handling.This validates the policy before gating and at Airflow, Dagster, and dbt configuration boundaries, with focused regression coverage and an Unreleased changelog entry.
Validation:
PYTHONPATH=src python -m pytest --no-cov -q tests/test_integrations/test_core.py tests/test_integrations/test_airflow.py tests/test_integrations/test_dagster.py tests/test_integrations/test_dbt.py(34 passed)ruff check src/freshdata/integrations tests/test_integrationsmypy src/freshdata/integrations